ppa-dev-tools

Merge ppa-dev-tools:improve-ppa-address-handling into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. improve-ppa-address-handling
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 8b8bb77ba229832de75930972b29b6a0aeca7b1a
Proposed branch: ppa-dev-tools:improve-ppa-address-handling
Merge into: ppa-dev-tools:main
Diff against target: 958 lines (+331/-225)
15 files modified
README.md (+2/-2)
ppa/ppa.py (+85/-37)
ppa/ppa_group.py (+21/-14)
scripts/ppa (+27/-37)
tests/helpers.py (+90/-0)
tests/test_io.py (+5/-2)
tests/test_job.py (+6/-15)
tests/test_lp.py (+2/-1)
tests/test_ppa.py (+48/-5)
tests/test_ppa_group.py (+29/-87)
tests/test_result.py (+1/-1)
tests/test_scripts_ppa.py (+1/-13)
tests/test_subtest.py (+1/-1)
tests/test_trigger.py (+1/-1)
tests/test_version.py (+12/-9)
Reviewer Review Type Date Requested Status
Lena Voytek (community) Approve
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+431612@code.staging.launchpad.net

Description of the change

Fixes some reported bugs relating to handling of the ppa-address argument to various commands.

This improves handling of cases where no team is specified (and thus should default appropriately to the current user's namespace), and catching a variety of invalid team and ppa names. A slew of test cases are added for this.

Of note, this also adds the ability to pass in a PPA url, in addition to a plain name or a formal ppa:foo/bar style address. I think this should make the commands a bit more handy.

To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

LGTM, just some small code cleanup comments. All logic looks good

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

I've incorporated fixes for all the feedback (and filed a bug for one), and landed the branch:

To git+ssh://git.launchpad.net/ppa-dev-tools
   222405e..e5b49d1 main -> main

Thank you again for the review, Lena!

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: