Merge ppa-dev-tools:trigger-action-urls into ppa-dev-tools:main
Proposed by
Bryce Harrington
| Status: | Merged |
|---|---|
| Merge reported by: | Bryce Harrington |
| Merged at revision: | 6c02046c2d30b1f59b30cb5485c57d806de3afaa |
| Proposed branch: | ppa-dev-tools:trigger-action-urls |
| Merge into: | ppa-dev-tools:main |
| Diff against target: |
237 lines (+84/-29) 4 files modified
ppa/ppa.py (+6/-7) ppa/trigger.py (+31/-5) scripts/ppa (+19/-4) tests/test_trigger.py (+28/-13) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Christian Ehrhardt (community) | Approve | ||
| Canonical Server | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
Starts integrating Trigger objects into the `ppa tests` command, and adds the action urls (the urls that actually cause autopkgtest to fire up the tests). Also adds the PPA element to the Triggers, which for now are required but later I think I could make that optional in order to make this code work for triggering directly against -proposed.
For now this just dumps the action urls to the output.
To post a comment you must log in.
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm generally +1 this is small and a good step forward.
One question on URL escaping and testing it below.
Feel free to add it here or putting it onto your known-todo-list.