ppa-dev-tools

Merge ppa-dev-tools:packaging-snaps into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. packaging-snaps
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 5fe77eb0c208147db3b301cae3c8107e32402099
Proposed branch: ppa-dev-tools:packaging-snaps
Merge into: ppa-dev-tools:main
Diff against target: 104 lines (+50/-10)
3 files modified
INSTALL.md (+7/-0)
RELEASING.md (+20/-2)
snap/snapcraft.yaml (+23/-8)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+430590@code.staging.launchpad.net

Description of the change

Snap packaging changes

I'd added a prelim snapcraft.yaml a few months ago but it never worked. This branch brings it up to date and makes it functional.

My snapcraft know-how is super thin, so I'd very much appreciate strong critiquing of this both in terms of correctness and style. I referenced snap packaging from git-ubuntu, ustriage, and dsctriage.

I've not yet produced an official snap for 0.2.0 yet, and am thinking with this MP landed I may do a 0.2.1 and snap that, since that'll include the INSTALL doc changes and other assorted fixes from the debian branch.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

I've tested the snap on a single jammy lxc container. I'm hoping to have broader testing and would definitely appreciate if others can test installing the snap before I announce.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

apps:
  ppa:
...
  aliases: [ppa]

Should give you the "ppa" name

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

     source: https://git.launchpad.net/ppa-dev-tools
     source-type: git

That is great to e.g. CI build.
But AFAIU this will build from there even with different local content.
It might be what you want and you can keep it.
But if you commit something locally and run snapcraft it will not have this new content until pushed.

While it is a bit low-tech, for me
   source: .
behaved often more how I liked it.

Entirely up to you as it depends on how you wanted to build things regularly.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

You are running in devmode anyway for now, but planning forward I think the "home" plug makes sense as that is where you'd expect users to have their local content.

Revision history for this message
Bryce Harrington (bryce) wrote :

> apps:
> ppa:
> ...
> aliases: [ppa]
>
> Should give you the "ppa" name

Aha, excellent thanks. I was searching all over the place to see if there was a way to do this.

Revision history for this message
Bryce Harrington (bryce) :
Revision history for this message
Bryce Harrington (bryce) wrote :

> source: https://git.launchpad.net/ppa-dev-tools
> source-type: git
>
> That is great to e.g. CI build.
> But AFAIU this will build from there even with different local content.
> It might be what you want and you can keep it.
> But if you commit something locally and run snapcraft it will not have this
> new content until pushed.
>
> While it is a bit low-tech, for me
> source: .
> behaved often more how I liked it.
>
> Entirely up to you as it depends on how you wanted to build things regularly.

Okay. Yeah I was banging my head over why it was not packaging new content changes, and couldn't find anything via google, so this solves that for me. Thank you!!

Revision history for this message
Bryce Harrington (bryce) wrote :

I've added commits for these suggestions and re-pushed the branch.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

My snap knowledge is as limited as your or worse, but at least from my POV this is good to go for 0.2 level.
+1

Feel free to ask for more reviews if you want more confidence :-)

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, landed.

To git+ssh://git.launchpad.net/ppa-dev-tools
   9be6571..0ac612e main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: