Merge ppa-dev-tools:add-results-output-to-tests-command into ppa-dev-tools:main

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 2cc3f55fe52953a9e30f4020c81914faa90386ae
Proposed branch: ppa-dev-tools:add-results-output-to-tests-command
Merge into: ppa-dev-tools:main
Diff against target: 473 lines (+107/-72)
6 files modified
INSTALL.md (+1/-0)
ppa/result.py (+5/-3)
ppa/subtest.py (+10/-11)
scripts/ppa (+60/-32)
tests/test_scripts_ppa.py (+3/-3)
tests/test_subtest.py (+28/-23)
Reviewer Review Type Date Requested Status
Lena Voytek (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+429930@code.staging.launchpad.net

Description of the change

This merge focuses on adding the missing Results display for the `ppa tests` command.

To test, I've been doing:

  $ python3 -m ppa.subtest
  $ python3 -m ppa.result
  $ pytest-3
  $ ./scripts/ppa tests ppa:bryce/nginx-merge-v1.22.0-1

I noticed a number of bugs along the way, and include fixes. There's likely more I just haven't hit yet, and there's definitely use cases I haven't gotten to.

The output does not yet match lp-test-ppa but it's working in that direction.

To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

These changes all look good to me! I have a few nitpicks to make things a bit cleaner if needed.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Btw thanks, looks like I merged this but didn't "save comment".

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: