PDBQ

Merge pdbq:pkg-bug-create-with-multi-packages into pdbq:main

  1. Git
  2. lp:pdbq
  3. pkg-bug-create-with-multi-packages
  4. Merge into main
Proposed by Bryce Harrington
Status: Needs review
Proposed branch: pdbq:pkg-bug-create-with-multi-packages
Merge into: pdbq:main
Diff against target: 471 lines (+151/-83)
2 files modified
pdbq/bug.py (+5/-3)
scripts/pkg-bug (+146/-80)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+452847@code.staging.launchpad.net

Description of the change

The main purpose of this branch is to add a capability when filing a bug report, to target multiple packages. This feature was required for filing the server-backport PPA update card in pdbq/pinot.

I'm piggybacking some cleanup and refactoring along with this.

At this point I'm not writing tests for pkg-bug, at least not for the bug filing workflow as I supervise it pretty closely to catch and handle errors.

An example input JSON file for creating a bug report with multiple packages is:
    https://paste.ubuntu.com/p/88v822S89K/

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Nice work, as usual! Thanks, Bryce :)

The only nitpick comment I have is that the first commit was a bit bloated since it contains more than announced (variables moving around, new try/except block,...). This is not an actionable comment not a blocker though.

LGTM!

review: Approve
Reply
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Athos, yeah that commit was a bit catch-all of various things at the time I didn't feel worth splitting out more fine-grained, but in the future I'll try to be more attentive to that.

I've rebased this branch on main, resolved a few conflicts, and force pushed.

stirling: ~/src/Pdbq/pdbq-pkg-bug$ git merge --ff-only pkg-bug-create-with-multi-packages
Updating 366d814..94398d8
Fast-forward
 pdbq/bug.py | 8 ++--
 scripts/pkg-bug | 224 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
 scripts/pkg-updates | 3 +-
 3 files changed, 151 insertions(+), 84 deletions(-)
stirling: ~/src/Pdbq/pdbq-pkg-bug$ git push --force
Enumerating objects: 37, done.
Counting objects: 100% (37/37), done.
Delta compression using up to 12 threads
Compressing objects: 100% (31/31), done.
Writing objects: 100% (31/31), 4.89 KiB | 2.44 MiB/s, done.
Total 31 (delta 24), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/pdbq
 + b45f241...94398d8 main -> main (forced update)

Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: