Merge pdbq:introduce-mp-addresses into pdbq:main
Status: | Merged |
---|---|
Merge reported by: | Bryce Harrington |
Merged at revision: | 730843ca5c13e6122eb94172a0a2125cf40e7c5a |
Proposed branch: | pdbq:introduce-mp-addresses |
Merge into: | pdbq:main |
Diff against target: |
343 lines (+163/-51) 2 files modified
pdbq/merge_proposal.py (+76/-12) tests/test_merge_proposal.py (+87/-39) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Athos Ribeiro (community) | Needs Information | ||
Canonical Server Core Reviewers | Pending | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+450375@code.staging.launchpad.net |
Description of the change
This branch introduces a new notion of shorthand MP addresses, similar to PPA addresses and LP: #'s. So, this MP could be referenced as:
mp:
That's enough info to translate into the full URL. There are some complexities involved, which I elaborate about in the commit message. Since for now this is merely cosmetic for display purposes I'm not bothering with properly documenting it, let alone making a spec about it, but if this ends up being actually useful those would be logical actions to take next. (The right time for that action is most likely around when a parser is going to be written for it.)
Where I envision using this is in the summary listings of reviews, for both web page and command line. Currently, the value is seen when running `pkg-mp list`, which I recommend doing to test.
Example output:
* pdbq: MP #450375
- address: mp:bryce/
- requester: bryce
- requester_name: Bryce Harrington
- requester_url: https:/
- date_created: Thu Aug 31 20:27:21 2023
- date_requested: Thu Aug 31 20:27:21 2023
- date_reviewed: None
- date_merged: None
- source_repo: https:/
- source_branch: introduce-
- target_repo: https:/
- target_branch: main
* python-
- address: mp:lvoytek/
- requester: lvoytek
- requester_name: Lena Voytek
- requester_url: https:/
- date_created: Thu Aug 31 20:55:55 2023
- date_requested: Thu Aug 31 20:55:55 2023
- date_reviewed: None
- date_merged: None
- source_repo: https:/
- source_branch: django4-
- target_repo: https:/
- target_branch: ubuntu/devel
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Thanks, Bryce.
I am reviewing this one :)