PDBQ

Merge pdbq:implement-mre-card-support into pdbq:main

  1. Git
  2. lp:pdbq
  3. implement-mre-card-support
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 4a06dadb9cbf2afff9f1e27a6cc740dfed1f6be6
Proposed branch: pdbq:implement-mre-card-support
Merge into: pdbq:main
Diff against target: 571 lines (+251/-67) (has conflicts)
6 files modified
.pylintrc (+5/-0)
pdbq/lp.py (+26/-0)
scripts/pkg-bug (+3/-2)
scripts/pkg-updates (+122/-59)
tests/test_lp.py (+40/-0)
workers/query-mre-backport-packages-by-team (+55/-6)
Conflict in .pylintrc
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+447244@code.staging.launchpad.net

Description of the change

This implements some changes to support MRE cards in Pinot, in followup to the topic raised in today's meeting (July 19th).

I'd actually had these changes hanging around half-finished for some time, based on review feedback from the original roll-out of this functionality. Changes include grouping like sets of packages together into a data object I'm terming 'Software'. Snap and OCI update support is gone, and preliminary support for PPA updates is also added.

I've lightly updated the list of MRE targets, however I'm aware there are likely others missing so this list is just preliminary until I've collected input from the rest of the team. For PPA updates, currently that is only the canonical-server PPA.

For now, I'm not worrying about tests and documentation for any of this code; these are scripts that are going to be run manually, and only once per cycle, and will probably need a little fiddling with each time, so they don't need a super high level of QA. However, that said, feedback on improvements is quite welcome!

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM. I only added an inline commenting regarding postgresql-13.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Athos, I've made that correction (and the .pylintrc merge conflict) and pushed to main:

stirling: ~/src/Pdbq/pdbq-reviews$ git merge --ff-only implement-mre-card-support
Updating efd2af7..aad9d01
Fast-forward
 .pylintrc | 2 +-
 pdbq/lp.py | 26 ++++++++++
 scripts/pkg-bug | 5 +-
 scripts/pkg-updates | 181 ++++++++++++++++++++++++++++++++++++++++++++---------------------
 tests/test_lp.py | 40 +++++++++++++++
 workers/query-mre-backport-packages-by-team | 61 +++++++++++++++++++---
 6 files changed, 247 insertions(+), 68 deletions(-)

stirling: ~/src/Pdbq/pdbq-reviews$ git push
Enumerating objects: 84, done.
Counting objects: 100% (84/84), done.
Delta compression using up to 12 threads
Compressing objects: 100% (73/73), done.
Writing objects: 100% (73/73), 11.93 KiB | 2.98 MiB/s, done.
Total 73 (delta 55), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/pdbq
   b56e64d..e56fb2c main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: