PDBQ

Merge pdbq:implement-tests-for-merge-proposal-class into pdbq:main

  1. Git
  2. lp:pdbq
  3. implement-tests-for-merge-proposal-class
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 7e3eeb72446cc6ed0c71e6d6941dcd4668e05320
Proposed branch: pdbq:implement-tests-for-merge-proposal-class
Merge into: pdbq:main
Diff against target: 623 lines (+341/-98)
3 files modified
pdbq/merge_proposal.py (+15/-5)
scripts/pkg-mp (+9/-7)
tests/test_merge_proposal.py (+317/-86)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server packageset reviewers Pending
PpaDevTools Developers Pending
Canonical Server Reporter Pending
Review via email: mp+446886@code.staging.launchpad.net

Description of the change

This adds a to_dict() function to the MergeProposal class along with a large spate of test cases to cover the class' core functionalities.

More work is coming for the MergeProposal class that builds on top of the core functions, and so you may notice some tests are still marked as "Unimplemented". But I wanted to get the test suite into better shape before adding further functionality.

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM, thanks Bryce!

Initially, I had some issues with testing this due to issues with the setup.py file, but they are not related at all.

The issues I found there were

- related to the required runtime deps, which include the python standard lib modules (e.g., json). This confuses pip when parsing the dependencies; and
- the param passed to get_verison in setup.py.

These are no blockers for this change though, approved.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Athos, I've rebased and pushed to main:

stirling: ~/src/Pdbq/pdbq-pkg-mp$ git merge --ff-only implement-tests-for-merge-proposal-class
Updating 76e4825..3edc8af
Fast-forward
 pdbq/merge_proposal.py | 20 +++-
 scripts/pkg-mp | 16 ++--
 tests/test_merge_proposal.py | 403 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------
 3 files changed, 341 insertions(+), 98 deletions(-)
stirling: ~/src/Pdbq/pdbq-pkg-mp$ git push
Enumerating objects: 25, done.
Counting objects: 100% (25/25), done.
Delta compression using up to 12 threads
Compressing objects: 100% (18/18), done.
Writing objects: 100% (18/18), 5.10 KiB | 2.55 MiB/s, done.
Total 18 (delta 13), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/pdbq
   76e4825..3edc8af main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: