PDBQ

Merge pdbq:pkg-bug-milestones into pdbq:main

  1. Git
  2. lp:pdbq
  3. pkg-bug-milestones
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 3187b79a9132037eb760599ed01f88e4d628fc7c
Proposed branch: pdbq:pkg-bug-milestones
Merge into: pdbq:main
Diff against target: 237 lines (+82/-48)
1 file modified
scripts/pkg-bug (+82/-48)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+442501@code.staging.launchpad.net

Description of the change

In the process of creating the merge board, `pkg-bug` performs the step of creating the actual bug reports. For mantic, there were some problems with the bug metadata (notably including the milestones) not getting set.

This branch provides the correction for that problem, and does some other general cleanup.

(pkg-bug needs a lot more development attention (there's no tests yet) but that work will come periodically through the cycle. So suggestions for future improvements welcome.)

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

- missing lp_save(): check
- dry_run: check
- whitespace and minor refactorings: check

What about the new scripts/run-watch that appears in the diff, together with this commit?

commit 3eaae8abf2d3333dae10cb0cdd851bffb639f7bf
Author: Bryce Harrington <email address hidden>
Date: Mon May 8 18:00:59 2023 -0700

    pkg-bug: Rename create_parser() to disambiguate

scripts/run-watch is not called anywhere else in the code yet, afaik.

review: Needs Information
Revision history for this message
Bryce Harrington (bryce) wrote :

Good catch, yes that new script seems to have slipped in prematurely.
I've dropped it from this MP and force re-pushed.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks; pushed:

Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/pdbq
   da427ed..3187b79 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: