Merge lp://staging/~bryce/launchpad/lp-253509 into lp://staging/launchpad/db-devel
Proposed by
Bryce Harrington
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9398 | ||||
Proposed branch: | lp://staging/~bryce/launchpad/lp-253509 | ||||
Merge into: | lp://staging/launchpad/db-devel | ||||
Diff against target: |
82 lines (+32/-5) 2 files modified
lib/canonical/launchpad/mailnotification.py (+4/-1) lib/lp/bugs/doc/security-teams.txt (+28/-4) |
||||
To merge this branch: | bzr merge lp://staging/~bryce/launchpad/lp-253509 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | code | Approve | |
Jelmer Vernooij (community) | code* | Approve | |
Review via email: mp+25655@code.staging.launchpad.net |
Commit message
When transitioning a bug from one project to another, only subscribe the new project's security team if the bug was marked as a security issue.
Description of the change
Modifies update_
To post a comment you must log in.
Hi Bryce,
Welcome to Launchpad!
Docstrings should start on the same line as the opening quotes (line 8 of your patch).
It would be great to have a test that ensures update_ security_ contact_ subscriptions works as expected and doesn't subscribe the security contact for non-security issues but does for security issues. Otherwise, seems good.