Launchpad itself

Merge lp://staging/~bryce/launchpad/component-url-formatter into lp://staging/launchpad

  1. component-url-formatter
  2. Merge into devel
Proposed by Bryce Harrington
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 13430
Proposed branch: lp://staging/~bryce/launchpad/component-url-formatter
Merge into: lp://staging/launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/bugs/templates/bugtracker-portlet-components.pt (+1/-1)
To merge this branch: bzr merge lp://staging/~bryce/launchpad/component-url-formatter
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+67783@code.staging.launchpad.net

Commit message

[r=jtv][no-qa] Refactor component editing with URL formatter

Description of the change

Refactor component editing with URL formatter

Suggested in code review of another branch by Jeroen and Gavin.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Sweet.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Jeroen, thanks for the review! However, when I attempt to land it I get the error message, "ec2: ERROR: Merge proposal is not approved. Get it approved, or use --force to land it without approval." Perhaps I no longer have permission to land branches? Would you mind submitting it for me?

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Better now?

Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good, thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.