Launchpad itself

Merge lp://staging/~bryce/launchpad/bugtracker-refactor into lp://staging/launchpad

  1. bugtracker-refactor
  2. Merge into devel
Proposed by Bryce Harrington
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: no longer in the source branch.
Merged at revision: 13431
Proposed branch: lp://staging/~bryce/launchpad/bugtracker-refactor
Merge into: lp://staging/launchpad
Diff against target: 52 lines (+11/-13)
2 files modified
lib/lp/bugs/browser/bugalsoaffects.py (+7/-7)
lib/lp/bugs/browser/bugtracker.py (+4/-6)
To merge this branch: bzr merge lp://staging/~bryce/launchpad/bugtracker-refactor
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+67781@code.staging.launchpad.net

Commit message

[r=jtv][no-qa] Minor cleanup refactoring for bugtracker component code.

Description of the change

Some code cleanup spotted by Jeroen during the review of another branch.

No functional changes introduced with these refactorings. Being merged independently to keep branch sizes manageable.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks. Very thoughtful.

I'm talking, of course, about your spelling my name correctly. But the code's nice too.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Jeroen, thanks for the review! However, when I attempt to land it I get the error message, "ec2: ERROR: Merge proposal is not approved. Get it approved, or use --force to land it without approval." Perhaps I no longer have permission to land branches? Would you mind submitting it for me?

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Did you set the status to Approved? The "ec2 land" procedure requires that. The jury's still out on whether it's up to the reviewer or the reviewee to set that; personally I like to keep it as a last checkpoint for the reviewee, whose responsibility it is after all to seek out all the reviews the branch needs and see to it that they're all completed.

I set the status for you. That should get you past this error. Could you try landing again?

Revision history for this message
Bryce Harrington (bryce) wrote :

Jeroen, unfortunately as I am now relegated to a mere community contributor I can no longer set branches to Approved. bac says only members of ~launchpad-reviewers can do that.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for setting it to Approved, ec2 land accepted it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.