Merge lp://staging/~bryce/launchpad/api-docs-fixes-bug into lp://staging/launchpad
Proposed by
Bryce Harrington
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Bryce Harrington | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 10960 | ||||||||
Proposed branch: | lp://staging/~bryce/launchpad/api-docs-fixes-bug | ||||||||
Merge into: | lp://staging/launchpad | ||||||||
Diff against target: |
231 lines (+30/-22) 9 files modified
lib/lp/bugs/browser/bug.py (+1/-1) lib/lp/bugs/doc/bugmessage.txt (+1/-1) lib/lp/bugs/interfaces/bug.py (+20/-12) lib/lp/bugs/interfaces/bugtask.py (+1/-1) lib/lp/bugs/interfaces/malone.py (+1/-1) lib/lp/code/doc/branch-visibility.txt (+1/-1) lib/lp/code/model/tests/test_branchnamespace.py (+3/-3) lib/lp/code/stories/branches/xx-branch-edit-privacy.txt (+1/-1) lib/lp/registry/browser/team.py (+1/-1) |
||||||||
To merge this branch: | bzr merge lp://staging/~bryce/launchpad/api-docs-fixes-bug | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eleanor Berger (community) | code | Approve | |
Review via email: mp+25798@code.staging.launchpad.net |
Commit message
Flesh out docs for interfaces/bugs.py and fix various spelling errors.
Description of the change
Further improvements to the API documentation and spelling fixes.
Most notably includes fleshing out docs of interfaces/bugs.py, and fixing the spelling of 'visiblity' which appears throughout the codebase including in a user-visible string (reported as bug #455203), and clarifying that setCommentVisib
To post a comment you must log in.
Bryce, all-in-all very nice improvements. There are a few potential problems though, resulting from the way interfaces are used in the UI. In Zope (and Launchpad), the same interfaces that are used to define objects can be used for publishing these objects. Many Launchpad forms, for example, use the Description attribute of fields to render the descriptive text next the field (the same goes for Title). The advantage of this approach is that you don't need to describe the same field twice. The disadvantage, is that the title and description you use must be appropriate both for use in the model and for use in the UI. Some of the titles and descriptions you've added might not be appropriate for the UI (the description for tags, for example, that appears on a bug's +edit page). For the same reason, some of the changes you've made are likely to require changes to pagetests, which I think you haven't adjusted yet in this branch. I think that the changes are good in most cases, but let's go once over the visible changes and make sure they work fine, and perhaps also submit this for UI-review.
b.t.w If you find places where you think the description should be different, all hope is not lost - it is still possible to customize the appearance of fields in the UI by changing them in the relevant classes in the the browser package.