GTG

Merge lp://staging/~bryce/gtg/notebook into lp://staging/~gtg/gtg/old-trunk

notebook
Merge into old-trunk

Proposed by Bryce Harrington on 2010-02-22

Status:

Merged

Merge reported by:

Bryce Harrington

Merged at revision:

not available

Proposed branch:

lp://staging/~bryce/gtg/notebook

Merge into:

lp://staging/~gtg/gtg/old-trunk

Diff against target:

222 lines (+139/-9) (has conflicts)

2 files modified

GTG/taskbrowser/browser.py (+99/-0)
GTG/taskbrowser/taskbrowser.glade (+40/-9)

Text conflict in GTG/taskbrowser/browser.py
Text conflict in GTG/taskbrowser/taskbrowser.glade

To merge this branch:

bzr merge lp://staging/~bryce/gtg/notebook

Related bugs:

Bug #324254: Statistics on the work done	Wishlist	Invalid
Bug #341871: Implement a task detail pane to show in the main taskbrowser window	Wishlist	Won't Fix

Link a bug report

Reviewer	Date Requested	Status
Luca Invernizzi (community)		Needs Fixing on 2010-02-23
Bertrand Rousseau (community)	2010-02-22	Needs Fixing on 2010-02-22
Review via email: mp+19912@code.staging.launchpad.net

Revision history for this message

Bryce Harrington (bryce) wrote on 2010-02-22:

This provides plugins with a clean way to add panes to the UI via notebook tabs similar to how gedit works.

See branch description for more info.

Revision history for this message

Bertrand Rousseau (bertrand-rousseau) wrote on 2010-02-22:

If I disable the closed task pane, the treeview disappear, but not the pane, leaving a grey empty space.

review: Needs Fixing

Revision history for this message

Luca Invernizzi (invernizzi) wrote on 2010-02-23:

That's very nice, as it opens a new way to interact with the user without bugging him too much.
The ideas you're listing in the branch description are all interesting. I'll add one: a calendar view, to schedule the tasks. While I wouldn't find that particularly useful, we have lots of bugs on "notifying to execute a task", set a task duration ...

I also have Bertrand issue, so I'll mark this as the dreaded "need fixing" (plugin idea: learn an adjective in a foreign language every day :-D ).

Reading through the code, I've seen that you reverted the fix to set a minimum height for the closed task pane. Is that intended (and, if so, why)?

For the future (I'm just listing ideas), we should change the menu entry in the "view" menu from "show closed task pane" to something more appropriate.

Again, great work.

review: Needs Fixing

Revision history for this message

Bryce Harrington (bryce) wrote on 2010-02-23:

On Tue, Feb 23, 2010 at 12:52:48AM -0000, Luca Invernizzi wrote:
> Reading through the code, I've seen that you reverted the fix to set a minimum height for the closed task pane. Is that intended (and, if so, why)?
>

Not intended, probably just a merge issue I overlooked.