Merge lp://staging/~bryce/gtg/0.3-notebook into lp://staging/~gtg/gtg/old-trunk
Proposed by
Bryce Harrington
| Status: | Merged |
|---|---|
| Approved by: | Bryce Harrington |
| Approved revision: | not available |
| Merged at revision: | 746 |
| Proposed branch: | lp://staging/~bryce/gtg/0.3-notebook |
| Merge into: | lp://staging/~gtg/gtg/old-trunk |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp://staging/~bryce/gtg/0.3-notebook |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gtg developers | Pending | ||
|
Review via email:
|
|||
Description of the change
This provides plugins with a clean way to add panes to the UI via notebook tabs similar to how gedit works.
This is a rebase of my previous notebook work to the 0.3 codebase. It's been improved based on the previous review comments. The closed_pane has been turned into just a regular notebook page that can be added/removed as any other. Notebooks now hide themselves when the last page is removed. This should make it behave properly when the closed pane is toggled on and off.
I figure this should probably get one more round of review before going in, in case there are any other problems I've overlooked. Please test and let me know if you find problems.
See branch description for more info.
To post a comment you must log in.
Revision history for this message
| Luca Invernizzi (invernizzi) wrote | # |
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
It seems to work perfectly.
One little thing I noticed is that the default installation starts with an open empty notebook with height 0. If you quit the program and restart, however, it disappears.