Merge ~bryce/git-ubuntu:start-patch-pilot-tips-sheet into git-ubuntu:main

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: df77d7c491b169d6919810a11ab37ae0df0fbe2f
Proposed branch: ~bryce/git-ubuntu:start-patch-pilot-tips-sheet
Merge into: git-ubuntu:main
Diff against target: 222 lines (+216/-0)
1 file modified
doc/rst/howto/patch-pilot.rst (+216/-0)
Reviewer Review Type Date Requested Status
Robie Basak Approve
Andreas Hasenack Approve
Server Team CI bot continuous-integration Approve
Canonical Server Reporter Pending
Review via email: mp+451755@code.staging.launchpad.net

Description of the change

For my pilot shift I focused on starting work on a patch pilot manual, as discussed and tasked to me at the 25 Aug 2023 git-ubuntu feedback session. At this initial point the work is less of a manual and more of a semi-cohesive set of tips but hopefully useful none-the-less and maybe something others can use to hang additional docs on.

Due to time limitation I focused all my time on content, rather than formatting, and other than making sure `rstcheck` passes successfully on it I didn't verify the formatting validity. That'd be a good follow-on task.

There are also a few topics left empty. I think they're necessary questions for considering the document minimally useful, however didn't have time to fill them in. They're also left as suggested follow-on work for now.

I also can't say if this is the ideal place to house the document; again my goal was more about content generation. Feel free to move this or rename it to fit better into the overall documentation structure.

I'd like to highlight the section that outlines a paint-by-numbers workflow for mechanically converting a debdiff into a proper git-ubuntu branch. While much of the rest of this doc is rehashing info from elsewhere, this bit is new and I suspect quite pertinent to patch pilot as the initiative strives to move towards using a more git-ubuntu oriented workflow.

Anyway, hope this is helpful.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:8b8823937a3950d0c22d0e2303af584407abe7c0
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/41/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/41//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Andreas!

I've updated the branch with your feedback, squashed and re-pushed.

Revision history for this message
Robie Basak (racb) wrote :

Thank you for this!

This isn't a full review yet, but a quick drive by comment inline that's probably useful sooner rather than later.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:280c1f273ec320397c5225e4513c3da617dd940d
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/42/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/42//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

Branch updated with rbasak's feedback, thanks.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:df77d7c491b169d6919810a11ab37ae0df0fbe2f
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/43/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/43//rebuild

review: Approve (continuous-integration)
Revision history for this message
Andreas Hasenack (ahasenack) :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

Thank you for working on this! I suggested some tweaks including to fix formatting and pushed them here: https://git.launchpad.net/~racb/git-ubuntu/log/?h=start-patch-pilot-tips-sheet

+1 to merge when you're ready.

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

As a followup, it might be useful to try to combine and restructure the howtos as the ones being added here aren't all patch-pilot-specific. But this is infinitely better than not having this, so I think we should merge anyway and leave that for another time.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Andreas and Robie, I merged your improvements and pushed:

$ git push origin
Enumerating objects: 72, done.
Counting objects: 100% (72/72), done.
Delta compression using up to 12 threads
Compressing objects: 100% (51/51), done.
Writing objects: 100% (67/67), 10.30 KiB | 2.57 MiB/s, done.
Total 67 (delta 55), reused 17 (delta 16), pack-reused 0
To git+ssh://git.launchpad.net/git-ubuntu
   fa1a0b3..8d21849 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches