Merge ~bryce/git-ubuntu:sendmail-object into git-ubuntu:master

Proposed by Bryce Harrington
Status: Superseded
Proposed branch: ~bryce/git-ubuntu:sendmail-object
Merge into: git-ubuntu:master
Diff against target: 398 lines (+299/-46)
3 files modified
bin/import-source-packages.py (+5/-46)
gitubuntu/mailer.py (+145/-0)
gitubuntu/mailer_test.py (+149/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
git-ubuntu developers Pending
Review via email: mp+375740@code.staging.launchpad.net

Description of the change

This moves a chunk of untested code from bin/import-source-packages.py into a module and adds test cases. It uses the standard Python smtplib module, which is included with Python so needs no snapcraft alterations.

Followup work includes moving some of the configurable parameters to config handling, and providing more detailed information on why failed package imports failed. The configuration work can be tackled as part of trello card '57-configuration-support'. The failure tracking may be easiest to do as part of the importer rework to parallelize the import tasks (using co-routines or similar); not sure if we have a card or bug for that yet.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:ad10575b0fbfeef6f34dd1ec57cddf93fd1b97b3
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/398/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/398//rebuild

review: Needs Fixing (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches