Apport

Merge lp://staging/~bryce/apport/bug-1831802 into lp://staging/~apport-hackers/apport/trunk

bug-1831802
Merge into trunk

Proposed by Bryce Harrington on 2019-06-05

Status:

Work in progress

Proposed branch:

lp://staging/~bryce/apport/bug-1831802

Merge into:

lp://staging/~apport-hackers/apport/trunk

Diff against target:

32 lines (+8/-2)

1 file modified

data/general-hooks/generic.py (+8/-2)

To merge this branch:

bzr merge lp://staging/~bryce/apport/bug-1831802

Undecided

Invalid

Link a bug report

Reviewer	Review Type	Date Requested	Status
Apport upstream developers		2019-06-05	Pending
Review via email: mp+368415@code.staging.launchpad.net

Commit message

data/general-hooks/generic.py: Don't file bug reports about out-of-space conditions

For package installation problems, if the problem is due to insufficient
disk space then treat it as an unreportable error.

Fixes: LP: #1831802

Description of the change

If package installation failed due to out-of-disk-space, it isn't necessary to file a bug report about it, so filter these.

Revision history for this message

Bryce Harrington (bryce) wrote on 2019-06-05:

Googling a bit more, this error message may be originating from mysql, in which case an alternative approach might be to parse Df.txt for 100% usage on /.

I don't know how prevalent this particular type of bug report is. There is already code to check disk space at bug filing time, which may catch most of these, but won't catch if the system ran out of space during installation.

Revision history for this message

Brian Murray (brian-murray) wrote on 2019-06-05:

The error message does in fact come from mysql as we can in the presint:

167 # checking disc space
168 if LC_ALL=C BLOCKSIZE= df --portability $DATADIR/. | tail -n 1 | awk '{ exit ($4>1000) }'; then
169 echo "ERROR: There's not enough space in $DATADIR/" 1>&2
170 db_stop
171 exit 1
172 fi

So the string checking you've added would make more sense in the mysql apport package hook, that being said it is curious that the referenced bug report got reported to Launchpad at all. I'd have expected there to be an UnreportableReason regarding the partition not having enough free space.