Merge lp://staging/~brunonova/software-properties/lp1383289 into lp://staging/software-properties

Proposed by Bruno Nova
Status: Merged
Merged at revision: 920
Proposed branch: lp://staging/~brunonova/software-properties/lp1383289
Merge into: lp://staging/software-properties
Diff against target: 28 lines (+3/-3)
2 files modified
softwareproperties/SoftwareProperties.py (+2/-2)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+1/-1)
To merge this branch: bzr merge lp://staging/~brunonova/software-properties/lp1383289
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+238890@code.staging.launchpad.net

Description of the change

Dragging a key into the list of keys in the "Authentication" tab fails. This commit fixes this.
I tested only the GTK version! I don't know if the problem exists in the KDE one!

Note: in softwareproperties/gtk/SoftwarePropertiesGtk.py, I replaced one occurrence of "selection.data.strip()" by "selection.get_data().strip()".
But there is another occurrence of "selection.data.strip()" in that file, which is not used here. I haven't touched it because I am not sure if "selection" there is also of type "SelectionData". If it is, then that occurrence should be corrected as well!

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: