Merge lp://staging/~bruno-braga/terminator/suppress-multiple-terminals-dialog into lp://staging/terminator/trunk

Proposed by bruno.braga
Status: Merged
Merged at revision: 1292
Proposed branch: lp://staging/~bruno-braga/terminator/suppress-multiple-terminals-dialog
Merge into: lp://staging/terminator/trunk
Diff against target: 76 lines (+22/-6)
3 files modified
terminatorlib/config.py (+1/-0)
terminatorlib/container.py (+19/-2)
terminatorlib/window.py (+2/-4)
To merge this branch: bzr merge lp://staging/~bruno-braga/terminator/suppress-multiple-terminals-dialog
Reviewer Review Type Date Requested Status
Chris Jones (community) Approve
Review via email: mp+84951@code.staging.launchpad.net

Description of the change

I was thinking about doing this for years already, and finally had the time to take a look in Terminator's code to implement it. The gnome-terminal has similar popup alert message asking "are you sure you want to close this?" when you have many tabs in place. They offered a way out of this alert dialog, for those who do not want to see that every time they close the terminal.Their solution, however, was not that trivial, as you need to go to gconf and change settings yourself and manually.

For terminator case, it is much worse. In principle, because the main feature if offers is to have multiple terminals on screen. This alert message bugged me for long.

Checking the terminator code, I saw no configurations being handled by gconf (to address similar solution to gnome-terminal), so I added another key in the config.py, that will store a bool to indicate whether to display the alert or not. This decision, by the user, will be available when he closes the terminator application with multiple terminals for the first time, where a checkbox with the option "do not show this again" will be available.

It immitates a bit of other applications, so I think it is a good improvement to this application.

I am not an expert in pyGtk, so feel free to do further changes if needed, so this feature can be implemented in future versions of terminator.

Thank you,

To post a comment you must log in.
Revision history for this message
bruno.braga (bruno-braga) wrote :
Revision history for this message
Chris Jones (cmsj) :
review: Approve
Revision history for this message
bruno.braga (bruno-braga) wrote :

Great! Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.