Ubuntu
bluez package

Merge lp://staging/~broder/ubuntu/precise/bluez/bluez-respawn into lp://staging/ubuntu/precise/bluez

  1. Precise (12.04)
  2. bluez-respawn
  3. Merge into precise
Proposed by Evan Broder
Status: Merged
Merged at revision: 88
Proposed branch: lp://staging/~broder/ubuntu/precise/bluez/bluez-respawn
Merge into: lp://staging/ubuntu/precise/bluez
Diff against target: 190 lines (+109/-29)
7 files modified
debian/bluez.bluetooth.default (+0/-20)
debian/bluez.bluetooth.upstart (+1/-9)
debian/bluez.maintscript (+1/-0)
debian/bluez.postrm (+49/-0)
debian/bluez.preinst (+45/-0)
debian/changelog (+12/-0)
debian/control (+1/-0)
To merge this branch: bzr merge lp://staging/~broder/ubuntu/precise/bluez/bluez-respawn
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
Review via email: mp+95979@code.staging.launchpad.net

Description of the change

Eliminate the /etc/default/bluetooth conffile - Upstart shouldn't be using /etc/default files just to enable/disable a job.

To smooth out the transition, if bluez has been disabled using /etc/default/bluetooth, migrate that setting to an Upstart override file.

I can upload this change myself, but I'd like a second pair of eyes to make sure I handled the fiddlier parts of the maintainer scripts correctly.

To post a comment you must log in.
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

looks good, though I'm used to doing the version comparison against the new version and not the 'latest broken one'

Revision history for this message
Evan Broder (broder) wrote :

Thanks for the feedback, Timo. I agree - it's not how I usually write those comparisons either, but it's what dpkg-maintscript-helper does, so I wanted to be consistent between my code and the autogenerated stuff.

I'll go ahead and upload this, then.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: