Drizzle

Merge lp://staging/~brianaker/drizzle/null-safety-fix-libdrizzle into lp://staging/~drizzle-trunk/drizzle/development

  1. null-safety-fix-libdrizzle
  2. Merge into development
Proposed by Brian Aker
Status: Merged
Approved by: Brian Aker
Approved revision: 2474
Merged at revision: 2478
Proposed branch: lp://staging/~brianaker/drizzle/null-safety-fix-libdrizzle
Merge into: lp://staging/~drizzle-trunk/drizzle/development
Diff against target: 3419 lines (+1362/-117)
16 files modified
libdrizzle-1.0/conn_local.h (+7/-1)
libdrizzle-1.0/t/client_server.c (+10/-1)
libdrizzle-1.0/t/drizzle_column_st.c (+12/-0)
libdrizzle/column.cc (+249/-9)
libdrizzle/command.cc (+18/-1)
libdrizzle/conn.cc (+387/-32)
libdrizzle/conn_uds.cc (+14/-1)
libdrizzle/drizzle.cc (+241/-25)
libdrizzle/field.cc (+83/-10)
libdrizzle/handshake.cc (+31/-6)
libdrizzle/mysql_password_hash.cc (+2/-1)
libdrizzle/pack.cc (+42/-7)
libdrizzle/query.cc (+148/-6)
libdrizzle/result.cc (+19/-11)
libdrizzle/row.cc (+87/-5)
libdrizzle/state.cc (+12/-1)
To merge this branch: bzr merge lp://staging/~brianaker/drizzle/null-safety-fix-libdrizzle
Reviewer Review Type Date Requested Status
Drizzle Merge Team Pending
Review via email: mp+86269@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Isn't this a logic error (precondition violation)?
Might be better to (also) use an assert.

Revision history for this message
Brian Aker (brianaker) wrote :

Agree, and disagree.... I think it might be worth it to generate a library for someone which does assert (and shows them how their code might break).

Library users have a tendency to miss things, and we don't want to cause an entire application to break.

Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Assert usually only applies to debug builds.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.