Code review comment for lp://staging/~brian.curtin/ubuntu-sso-client/py3-unicode

Revision history for this message
Alejandro J. Cura (alecu) wrote :

== Python Lint Notices ==

ubuntu_sso/qt/__init__.py:
    50: [W0511] TODO

ubuntu_sso/utils/compat.py:
    42: [W0622] Redefining built-in 'basestring'
    40: [C0103] Invalid name "text_type" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    41: [C0103] Invalid name "binary_type" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    42: [C0103] Invalid name "basestring" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    44: [C0103] Invalid name "text_type" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    45: [C0103] Invalid name "binary_type" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)
    46: [C0103] Invalid name "basestring" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)

ubuntu_sso/utils/webclient/common.py:
    286: [W0511] TODO

« Back to merge proposal