Merge lp://staging/~brian-murray/update-manager/karmic into lp://staging/~ubuntu-core-dev/update-manager/karmic

Proposed by Brian Murray
Status: Merged
Merged at revision: not available
Proposed branch: lp://staging/~brian-murray/update-manager/karmic
Merge into: lp://staging/~ubuntu-core-dev/update-manager/karmic
Diff against target: 27 lines
2 files modified
DistUpgrade/DistUpgrade.cfg (+1/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp://staging/~brian-murray/update-manager/karmic
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+14239@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

update-manager doesn't seem to check the value of EnableApport just whether or not it is in the config file. Subsequently, apport is being enabled on dist upgrades from Jaunty to Karmic.

From DistUpgrade/DistUpgradeController.py:

    def doDistUpgrade(self):
        # check if we want apport running during the upgrade
        if self.config.getWithDefault("Distro","EnableApport", False):
            self.enableApport()

1584. By Brian Murray

adding in bug number

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DistUpgrade/DistUpgrade.cfg'
2--- DistUpgrade/DistUpgrade.cfg 2009-10-20 14:25:42 +0000
3+++ DistUpgrade/DistUpgrade.cfg 2009-10-30 21:50:23 +0000
4@@ -29,7 +29,7 @@
5 PostUpgradeRemove=libflashsupport
6 PostUpgradeUpgrade=brasero
7 PostInstallScripts=./xorg_fix_proprietary.py
8-EnableApport=no
9+#EnableApport=no
10 # this supported blacklisting certain versions to ensure we do not upgrade
11 # to a known broken version. python2.6 was broken during intrepid->jaunty
12 BadVersions=python2.6_2.6.1-1ubuntu8,python-central_0.6.11ubuntu5
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2009-10-30 10:24:04 +0000
16+++ debian/changelog 2009-10-30 21:50:23 +0000
17@@ -1,3 +1,10 @@
18+update-manager (1:0.126.9) karmic-proposed; urgency=low
19+
20+ * DistUpgrade/DistUpgrade.cfg:
21+ - really stop enabling apport during the upgrade (LP: #465619)
22+
23+ -- Brian Murray <brian@ubuntu.com> Fri, 30 Oct 2009 13:54:08 -0700
24+
25 update-manager (1:0.126.8) karmic-proposed; urgency=low
26
27 * when the server is overloaded and no Release file information

Subscribers

People subscribed via source and target branches

to all changes: