Merge lp://staging/~brian-murray/launchpad/bug-supervisor-permissions into lp://staging/launchpad
Proposed by
Brian Murray
| Status: | Merged |
|---|---|
| Approved by: | Brian Murray |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11690 |
| Proposed branch: | lp://staging/~brian-murray/launchpad/bug-supervisor-permissions |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
82 lines (+31/-5) 3 files modified
lib/canonical/launchpad/security.py (+2/-1) lib/lp/bugs/model/bugtarget.py (+1/-1) lib/lp/registry/browser/tests/test_edit_permissions.py (+28/-3) |
| To merge this branch: | bzr merge lp://staging/~brian-murray/launchpad/bug-supervisor-permissions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Māris Fogels (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Allow a distribution's bug supervisor to set source package bug reporting guidelines and acknowledgment.
Description of the change
This branch grants the distribution bug supervisor the ability to edit distribution source package's +edit page. This allows them to set the package's bug reporting guidelines and bug reporting acknowledgment.
A test for this was added to test_edit_
bin/test -cvvt test_edit_
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is a great change. The test helpers make the change very clean and readable. r=mars
One suggestion for readability: consider renaming self.target and setupTarget() to something like self.context and setupViewContext(). I had to open the base class docstring to understand what the 'target' created by setupTarget actually is.
Maris