Merge lp://staging/~brian-murray/launchpad/bug-supervisor-nominate-for-release into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Aaron Bentley |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11774 |
| Proposed branch: | lp://staging/~brian-murray/launchpad/bug-supervisor-nominate-for-release |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
839 lines (+351/-124) 17 files modified
lib/canonical/launchpad/interfaces/ftests/validation.txt (+6/-2) lib/canonical/launchpad/security.py (+24/-0) lib/lp/bugs/browser/bug.py (+6/-3) lib/lp/bugs/browser/tests/bug-nomination-views.txt (+22/-12) lib/lp/bugs/browser/tests/bug-views.txt (+20/-6) lib/lp/bugs/configure.zcml (+20/-20) lib/lp/bugs/doc/bug-nomination.txt (+27/-14) lib/lp/bugs/model/bug.py (+7/-0) lib/lp/bugs/stories/bug-release-management/30-nominate-bug-for-distrorelease.txt (+45/-29) lib/lp/bugs/stories/bug-release-management/40-nominate-bug-for-productseries.txt (+46/-33) lib/lp/bugs/stories/bug-release-management/60-defer-product-bug.txt (+7/-1) lib/lp/bugs/stories/bug-release-management/xx-anonymous-bug-nomination.txt (+1/-2) lib/lp/bugs/stories/webservice/xx-bug.txt (+6/-0) lib/lp/bugs/tests/bugs-emailinterface.txt (+23/-0) lib/lp/bugs/tests/test_bugsupervisor_bugnomination.py (+85/-0) lib/lp/registry/interfaces/distribution.py (+1/-1) lib/lp/testing/factory.py (+5/-1) |
| To merge this branch: | bzr merge lp://staging/~brian-murray/launchpad/bug-supervisor-nominate-for-release |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Restrict the ability to nominate bugs for a release to bug supervisors, owners or drivers.
Description of the change
Bug 114766 is about making bug nominations more useful, for nomination reviewers, by restricting the number ability to nominate bugs for a release from anyone to the bug supervisor group. This is also something that the Ubuntu community is looking for as noted in bug 174375. I've setup the branch so the that only projects or distributions that have a bug supervisor set are affected by this change.
lib/lp/
restrict the enabling of the +nominate link to the bug supervisor team if set
lib/lp/
added check to ensure that nominator is a member of the correct team
lib/lp/
sorted permission attributes alphabetically
lib/lp/
add in a bug supervisor parameter to makeDistribution (one already exists for makeProject)
lib/lp/
modified tests 30- and 40- not to use sample data
60- added in a nomination that used to be in 30- or 40-
I added in test_bugsupervi
bin/test -cvvt test_bugsupervi
I've also modified the tests in bug-release-
bin/test -cvvt bug-release-
| Brian Murray (brian-murray) wrote | # |
| Aaron Bentley (abentley) | # |
Per IRC discussion, please change this so that the permission is only provided for bug supervisors.