Merge lp://staging/~brian-murray/launchpad/bug-605340 into lp://staging/launchpad

Proposed by Brian Murray
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11255
Proposed branch: lp://staging/~brian-murray/launchpad/bug-605340
Merge into: lp://staging/launchpad
Diff against target: 68 lines (+15/-5)
3 files modified
lib/canonical/launchpad/mailnotification.py (+1/-1)
lib/lp/bugs/doc/bugnotification-email.txt (+3/-1)
lib/lp/bugs/mail/bugnotificationbuilder.py (+11/-3)
To merge this branch: bzr merge lp://staging/~brian-murray/launchpad/bug-605340
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) code Approve
Review via email: mp+31221@code.staging.launchpad.net

Commit message

Add in an X-Launchpad-Bug-Modifier header to all bug mail that displays the creator's display name and name.

Description of the change

= Summary =

From bug 605340:

"The last launchpad rollout fixed bug 111147, no longer exposing the email address of people who have hidden them in the launchpad interface. The unfortunate side effect of this is that there's now no programmatic way to go from an emailed comment back to the either the identity of the commenter or the specific comment on the bug report."

Depending on what the final decision to do with the From: address is determining the commenter or player (if you will), will be even more problematic.

== Proposed fix ==

Add in an X-Launchpad-Bug-Modifier header to all bug mail that displays the player's display name and name.

== Tests ==

bin/test -cvv -t bugnotification-email

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks! I'm actually one of the people affected by this bug, I have a sieve rule that automatically marks my own comments as read.

The event_creator attribute is set but not used anywhere. Is it really necessary ?

The comment on line 57 lacks an ending dot, to be really pedantic.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.