Merge lp://staging/~brian-murray/launchpad/bug-605340 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Jelmer Vernooij |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11255 |
| Proposed branch: | lp://staging/~brian-murray/launchpad/bug-605340 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
68 lines (+15/-5) 3 files modified
lib/canonical/launchpad/mailnotification.py (+1/-1) lib/lp/bugs/doc/bugnotification-email.txt (+3/-1) lib/lp/bugs/mail/bugnotificationbuilder.py (+11/-3) |
| To merge this branch: | bzr merge lp://staging/~brian-murray/launchpad/bug-605340 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Add in an X-Launchpad-
Description of the change
= Summary =
From bug 605340:
"The last launchpad rollout fixed bug 111147, no longer exposing the email address of people who have hidden them in the launchpad interface. The unfortunate side effect of this is that there's now no programmatic way to go from an emailed comment back to the either the identity of the commenter or the specific comment on the bug report."
Depending on what the final decision to do with the From: address is determining the commenter or player (if you will), will be even more problematic.
== Proposed fix ==
Add in an X-Launchpad-
== Tests ==
bin/test -cvv -t bugnotification
Thanks! I'm actually one of the people affected by this bug, I have a sieve rule that automatically marks my own comments as read.
The event_creator attribute is set but not used anywhere. Is it really necessary ?
The comment on line 57 lacks an ending dot, to be really pedantic.