Merge lp://staging/~brian-murray/daisy/refill-srcversionbuckets into lp://staging/daisy

Proposed by Brian Murray
Status: Merged
Merged at revision: 324
Proposed branch: lp://staging/~brian-murray/daisy/refill-srcversionbuckets
Merge into: lp://staging/daisy
Diff against target: 25 lines (+1/-5)
1 file modified
tools/build_src_version_buckets.py (+1/-5)
To merge this branch: bzr merge lp://staging/~brian-murray/daisy/refill-srcversionbuckets
Reviewer Review Type Date Requested Status
Evan (community) Approve
Review via email: mp+161533@code.staging.launchpad.net

Description of the change

As noted in bug 1173345 some insertions were incorrectly skipped. This branch fixes that by not setting or checking Inserted at all but still uses an insertions list to keep track of (src_package, version) so that the same src_package and version are not inserted.

I don't believe this is worth testing as it is pretty clear what the error was.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: