Merge lp://staging/~brian-murray/daisy/changed-bucketsystems into lp://staging/daisy

Proposed by Brian Murray
Status: Merged
Merged at revision: 367
Proposed branch: lp://staging/~brian-murray/daisy/changed-bucketsystems
Merge into: lp://staging/daisy
Diff against target: 95 lines (+23/-20)
2 files modified
daisy/utils.py (+4/-12)
tools/build_bucketsystems.py (+19/-8)
To merge this branch: bzr merge lp://staging/~brian-murray/daisy/changed-bucketsystems
Reviewer Review Type Date Requested Status
Daisy Pluckers Pending
Review via email: mp+168212@code.staging.launchpad.net

Description of the change

See https://code.launchpad.net/~brian-murray/oops-repository/updated-bucket-systems/+merge/168211 for the reasoning behind this change.

This also contains an update to the backfill of the bucketsystems column family.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

On 7 June 2013 23:30, Brian Murray <email address hidden> wrote:
> + if version and version != '':
> + oopses.update_bucket_systems(oops_config, crash_signature, version,
> + system_uuid)

"if version" is sufficient here. An empty string in Python evaluates
to boolean false.

The rest looks good.

366. By Brian Murray

use new CF bucketversionsystems

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: