Merge lp://staging/~brian-murray/apport/test-fix into lp://staging/~apport-hackers/apport/trunk

Proposed by Brian Murray
Status: Merged
Merged at revision: 2981
Proposed branch: lp://staging/~brian-murray/apport/test-fix
Merge into: lp://staging/~apport-hackers/apport/trunk
Diff against target: 22 lines (+5/-3)
1 file modified
backends/packaging-apt-dpkg.py (+5/-3)
To merge this branch: bzr merge lp://staging/~brian-murray/apport/test-fix
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+264901@code.staging.launchpad.net

Description of the change

Fix this:

There is one failure left with Python 2:

======================================================================
ERROR: test_use_sources_for_a_ppa (__main__.T)
Use a sources.list.d file for a PPA.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_backend_apt_dpkg.py", line 1028, in test_use_sources_for_a_ppa
    'ubuntu', 'trusty', origins=['LP-PPA-%s' % ppa])
  File "backends/packaging-apt-dpkg.py", line 1372, in _build_apt_sandbox
    ppa_info = apport.packaging.json_request(ppa_archive_url)
  File "/home/martin/ubuntu/apport/trunk/apport/packaging_impl.py", line 282, in json_request
    return json.loads(content)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Ah, I was grepping for HTTPError only, so I missed that spot. Pulled. Thanks Brian!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches