Apport

Merge lp://staging/~brian-murray/apport/kernel-package-version into lp://staging/~apport-hackers/apport/trunk

  1. kernel-package-version
  2. Merge into trunk
Proposed by Brian Murray
Status: Merged
Merged at revision: 2799
Proposed branch: lp://staging/~brian-murray/apport/kernel-package-version
Merge into: lp://staging/~apport-hackers/apport/trunk
Diff against target: 89 lines (+29/-6)
5 files modified
apport/hookutils.py (+1/-1)
data/apportcheckresume (+7/-1)
data/iwlwifi_error_dump (+7/-1)
data/kernel_crashdump (+7/-1)
data/kernel_oops (+7/-2)
To merge this branch: bzr merge lp://staging/~brian-murray/apport/kernel-package-version
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Evan (community) Approve
Review via email: mp+217650@code.staging.launchpad.net

Description of the change

For kernel crashes when creating the crash file for the Package key we also need to add the version of the package otherwise the data in the error tracker is incomplete.

https://errors.ubuntu.com/bucket/?id=iwlwifi:22.24.8.0:0x00000038%20|%20BAD_COMMAND

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Looks good. We could probably refactor this into a separate function, but that's not worth blocking the MP on.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, thanks! Merging with a NEWS entry.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches