Merge lp://staging/~brendan-donegan/ubuntu-weather-app/remove_app_header_override into lp://staging/ubuntu-weather-app/obsolete.trunk
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Alan Pope 🍺🐧🐱 🦄 |
| Approved revision: | 390 |
| Merged at revision: | 391 |
| Proposed branch: | lp://staging/~brendan-donegan/ubuntu-weather-app/remove_app_header_override |
| Merge into: | lp://staging/ubuntu-weather-app/obsolete.trunk |
| Diff against target: |
50 lines (+0/-30) 1 file modified
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+0/-30) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/ubuntu-weather-app/remove_app_header_override |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Leo Arias (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Remove overridden AppHeader since the version in ubuntuuitoolkit works just fine. Also remove the redundant second copyright notice.
Description of the change
The overridden AppHeader custom proxy object was using a function that was removed from the UI toolkit helper (_show_
There was also a stray copyright header that was added by mistake so removed that as well.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, and if you say that the test pass, then +1.