ubuntu-system-settings

Merge lp://staging/~brendan-donegan/ubuntu-system-settings/autopilot_search_about_tests into lp://staging/ubuntu-system-settings

  1. autopilot_search_about_tests
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 713
Merged at revision: 720
Proposed branch: lp://staging/~brendan-donegan/ubuntu-system-settings/autopilot_search_about_tests
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 48 lines (+20/-3)
2 files modified
tests/autopilot/ubuntu_system_settings/tests/test_about.py (+10/-0)
tests/autopilot/ubuntu_system_settings/tests/test_search.py (+10/-3)
To merge this branch: bzr merge lp://staging/~brendan-donegan/ubuntu-system-settings/autopilot_search_about_tests
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+221122@code.staging.launchpad.net

Commit message

Add test for Check for Updates button and fix search test cases, plus add a new one for searches that shouldn't find anything.

Description of the change

Added a test for the 'Check for Updates' button in the AboutTestCase class. Press the button and make sure the appropriate screen appears.

Fixed the search test case as it was vulnerable to passing even if there was a problem. Now we make sure the Sound panel and only the Sound panel is shown.

Added a search test case to make sure nothing is found with an string that should not appear.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:713
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-system-settings/autopilot_search_about_tests/+merge/221122/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/842/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/504
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/450
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/34
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/34/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/34
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/954
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/979
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/979/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7790
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/397
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/588
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/588/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/842/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:713
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/843/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/518
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/465
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/35
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/35/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/967
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1001
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1001/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7814
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/411
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/603
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/603/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/843/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:713
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/844/
Executed test runs:
    None: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/523/console
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/467/console
    None: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/36/console
    None: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/36/console
    None: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/36/console
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1007/console
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/605/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/844/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:713
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/845/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/559
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/509
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/37/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/37
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1007
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1078
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1078/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7886
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/452
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/647
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/647/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/845/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks fine, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches