Merge lp://staging/~brendan-donegan/qtubuntu-sensors/bug1337284 into lp://staging/qtubuntu-sensors
Proposed by
Brendan Donegan
Status: | Merged |
---|---|
Approved by: | Ricardo Mendoza |
Approved revision: | 70 |
Merged at revision: | 70 |
Proposed branch: | lp://staging/~brendan-donegan/qtubuntu-sensors/bug1337284 |
Merge into: | lp://staging/qtubuntu-sensors |
Diff against target: |
12 lines (+1/-1) 1 file modified
plugins/sensors/core_orientation_sensor.cpp (+1/-1) |
To merge this branch: | bzr merge lp://staging/~brendan-donegan/qtubuntu-sensors/bug1337284 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Mendoza (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+225840@code.staging.launchpad.net |
Commit message
Initialize m_last{X,Y,Z} to avoid faulty values
Description of the change
The values of m_lastX, m_lastY and m_lastZ were not being initialized on creation. This allowed some faulty values to get through and corrupt the logic of the function, meaning that sometimes a rotation event could be issued for no reason. This branch fixes that, and I've tested that in the scenario where the unexpected rotation would occur, it no longer does.
To post a comment you must log in.
FAILED: Continuous integration, rev:70 /code.launchpad .net/~brendan- donegan/ qtubuntu- sensors/ bug1337284/ +merge/ 225840/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ qtubuntu- sensors- ci/56/ jenkins. qa.ubuntu. com/job/ qtubuntu- sensors- utopic- amd64-ci/ 22 jenkins. qa.ubuntu. com/job/ qtubuntu- sensors- utopic- armhf-ci/ 18 jenkins. qa.ubuntu. com/job/ qtubuntu- sensors- utopic- armhf-ci/ 18/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ qtubuntu- sensors- utopic- i386-ci/ 18
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qtubuntu- sensors- ci/56/rebuild
http://