Phablet Tools

Merge lp://staging/~brendan-donegan/phablet-tools/bug1411697 into lp://staging/phablet-tools

  1. bug1411697
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Needs review
Proposed branch: lp://staging/~brendan-donegan/phablet-tools/bug1411697
Merge into: lp://staging/phablet-tools
Diff against target: 16 lines (+4/-2)
1 file modified
phablet-test-run (+4/-2)
To merge this branch: bzr merge lp://staging/~brendan-donegan/phablet-tools/bug1411697
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Cris Dywan (community) Approve
Review via email: mp+246725@code.staging.launchpad.net

Commit message

Use exec_with_adb_user to create the temporary directory for pushing .deb files to

Description of the change

Create the temporary directory for copying .deb files to with exec_with_adb_user so that files can be adb pushed there without a permissions error

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

This won't suffice for deleting an existing problematic folder. You need "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

review: Needs Fixing
Reply
lp://staging/~brendan-donegan/phablet-tools/bug1411697 updated
335. By Brendan Donegan

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

336. By Brendan Donegan

No need for the second call to rm -rf

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

> This won't suffice for deleting an existing problematic folder. You need
> "exec_with_adb rm -rf /tmp/phablet-run-test/" to remove it in all cases.

Thanks, that is a possible corner case. Doing that makes the second call to rm -rf redundant too so I removed that

Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looking nice!

I'm obviously not a phablet team member, so I'm just approving this based on the fact that it solves the problems I was experiencing and somebody official will have to look into it.

review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:334
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/432/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/432/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:336
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/433/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-vivid-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/433/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

Any chance this will be reviewed?

Reply

Unmerged revisions

336. By Brendan Donegan

No need for the second call to rm -rf

335. By Brendan Donegan

Remove /tmp/phablet-run-test as root in case it exists from a previous run of the buggy version of phablet-test-run

334. By Brendan Donegan

Create temporary directory as the phablet user

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches