Merge lp://staging/~brendan-donegan/messaging-app/more_helpers_test into lp://staging/~iahmad/messaging-app/more_test_helpers
Proposed by
Brendan Donegan
| Status: | Rejected |
|---|---|
| Rejected by: | I Ahmad |
| Proposed branch: | lp://staging/~brendan-donegan/messaging-app/more_helpers_test |
| Merge into: | lp://staging/~iahmad/messaging-app/more_test_helpers |
| Diff against target: |
82 lines (+33/-18) 2 files modified
tests/autopilot/messaging_app/emulators.py (+19/-18) tests/autopilot/messaging_app/tests/test_messaging.py (+14/-0) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/messaging-app/more_helpers_test |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| I Ahmad | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-07-22.
Description of the change
Add CPO's for ContactListView and MultiRecipientI
Note that this depends on a helper to create a fake contact in order to work properly, so it can't quite be merged yet.
To post a comment you must log in.
Unmerged revisions
- 158. By Brendan Donegan
-
Removed superflous get_recipients helper method
- 157. By Brendan Donegan
-
Refactor helpers and add a test for them
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
