click

Merge lp://staging/~brendan-donegan/click/one_file_per_command_integration_tests into lp://staging/click/devel

one_file_per_command_integration_tests
Merge into devel

Proposed by Brendan Donegan on 2014-06-26

Status:	Merged
Approved by:	Colin Watson on 2014-07-02
Approved revision:	479
Merged at revision:	481
Proposed branch:	lp://staging/~brendan-donegan/click/one_file_per_command_integration_tests
Merge into:	lp://staging/click/devel
Diff against target:	396 lines (+211/-105) 10 files modified tests/integration/helpers.py (+1/-1) tests/integration/test_build.py (+26/-0) tests/integration/test_buildsource.py (+51/-0) tests/integration/test_chroot.py (+3/-2) tests/integration/test_contents.py (+33/-0) tests/integration/test_frameworks.py (+35/-0) tests/integration/test_info.py (+30/-0) tests/integration/test_install.py (+2/-2) tests/integration/test_integration.py (+0/-100) tests/integration/test_verify.py (+30/-0)
To merge this branch:	bzr merge lp://staging/~brendan-donegan/click/one_file_per_command_integration_tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Colin Watson (community)			Approve on 2014-07-02
Michael Vogt (community)		2014-06-26	Approve on 2014-06-30
PS Jenkins bot (community)	continuous-integration		Approve on 2014-06-26
Review via email: mp+224603@code.staging.launchpad.net

Commit message

Clean up integration tests - have one file per command and make some things clearer

Description of the change

Did some gardening of the integration tests. Put each commands tests in a seperate file. This does mean we end up with quite a few small files, but it's better than the alternative which was to put everything in a monolithic file. Also I renamed TestCase to ClickTestCase, to make it clearer that the integration tests are 'something extra' compared to unittest.TestCase

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-26:

FAILED: Continuous integration, rev:479
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/click/one_file_per_command_integration_tests/+merge/224603/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/click-devel-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-armhf-ci/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-i386-ci/8