Merge lp://staging/~brendan-donegan/checkbox/xls_report into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 2955
Proposed branch: lp://staging/~brendan-donegan/checkbox/xls_report
Merge into: lp://staging/checkbox
Diff against target: 76 lines (+32/-0)
3 files modified
checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml (+2/-0)
checkbox-gui/gui-engine/gui-engine.cpp (+27/-0)
checkbox-gui/gui-engine/gui-engine.h (+3/-0)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/xls_report
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Needs Information
Daniel Manrique (community) Approve
Review via email: mp+217455@code.staging.launchpad.net

Description of the change

When the submission.xml file is saved, also save the xlsx report.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks good, I'm OK with the empty options list, we can always change that once we implement client information support on the xlsx exporter (rather, generic option list support).

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

so two questions:

1) Do we want to do that unconditionally?
2) What happens when someone doesn't have python3-xslxwriter installed and the DBus call crashes?

review: Needs Information
Revision history for this message
Daniel Manrique (roadmr) wrote :

(set back to needs review pending answers to Zygmunt's comments - hopefully tarmac will check status *before* doing final merging)

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

(It does)

On Mon, Apr 28, 2014 at 5:13 PM, Daniel Manrique <
<email address hidden>> wrote:

> (set back to needs review pending answers to Zygmunt's comments -
> hopefully tarmac will check status *before* doing final merging)
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox/xls_report/+merge/217455
> You are reviewing the proposed merge of
> lp:~brendan-donegan/checkbox/xls_report into lp:checkbox.
>

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Or so I thought :D

On Mon, Apr 28, 2014 at 5:16 PM, <email address hidden> wrote:

> The proposal to merge lp:~brendan-donegan/checkbox/xls_report into
> lp:checkbox has been updated.
>
> Status: Needs review => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~brendan-donegan/checkbox/xls_report/+merge/217455
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox/xls_report/+merge/217455
> You are reviewing the proposed merge of
> lp:~brendan-donegan/checkbox/xls_report into lp:checkbox.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches