Merge lp://staging/~brendan-donegan/checkbox/story808_estimated_duration into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2189 |
| Merged at revision: | 2202 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/story808_estimated_duration |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
11 lines (+1/-0) 1 file modified
checkbox-old/plugins/jobs_info.py (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/story808_estimated_duration |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch just allows an estimated_duration field to be used in jobs so that we can experiment with using it.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It's a pretty simple change and tests revealed nothing breaks. Additional fields used to break the old message-passing protocol, but since that's no longer in use, this doesn't seem to be an issue.
Do keep in mind that at the moment, estimated_duration is limited to an integer. The data type can be changed later if desired, but do expect breakage if whatever is in that field can't be parsed into an integer.
Thanks!