Merge lp://staging/~brendan-donegan/checkbox/story791_c3_url into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2143
Merged at revision: 2141
Proposed branch: lp://staging/~brendan-donegan/checkbox/story791_c3_url
Merge into: lp://staging/checkbox
Diff against target: 72 lines (+17/-7)
3 files modified
examples/checkbox-hw-collection.ini (+5/-2)
plugins/final_prompt.py (+7/-2)
plugins/hexr_transport.py (+5/-3)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/story791_c3_url
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+165194@code.staging.launchpad.net

Description of the change

These are all the changes needed to support displaying the status URL in the certification UI.

Basically the hexr_transport plugin sets the text to display in the final_prompt plugin when the status url is recieved. It just displays the bare url unless html_link is set to True, this is so that the link will be clickable in the Qt UI.

Originally checkbox-hw-collection blacklisted final_prompt as it was using its own mechanism to display the status URL, but I removed that code so that the mechanism for displaying the status URL is the same across variants.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches