Checkbox

Merge lp://staging/~brendan-donegan/checkbox/ppa-packaging-plainbox-provider-canonical-certification into lp://staging/~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

  1. ppa-packaging-plainbox-provider-canonical-certification
  2. Merge into ppa-packaging-plainbox-pro...
Proposed by Brendan Donegan
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 13
Merged at revision: 13
Proposed branch: lp://staging/~brendan-donegan/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Merge into: lp://staging/~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Diff against target: 38 lines (+19/-1)
2 files modified
debian/changelog (+4/-0)
debian/control (+15/-1)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+217936@code.staging.launchpad.net

Description of the change

Add some dependencies that should have been there but weren't

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I guess this is ready for review now

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Looks good, +1

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

We need a specific version of fwts for certification, and I don't see that indicated here. Maybe it's worth doing another MR to amend that?

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Sure, I'm not sure which version that is so if you think it's missing just
do it.

On Fri, May 2, 2014 at 3:13 PM, Daniel Manrique <
<email address hidden>> wrote:

> We need a specific version of fwts for certification, and I don't see that
> indicated here. Maybe it's worth doing another MR to amend that?
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox/ppa-packaging-plainbox-provider-canonical-certification/+merge/217936
> Your team Checkbox Developers is subscribed to branch
> lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification.
>

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

The version we need is the one that is in universe. If we still need to update it, let's do that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches