Merge lp://staging/~brendan-donegan/checkbox/fwts_remove_dmidecode_smbios into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2371
Merged at revision: 2371
Proposed branch: lp://staging/~brendan-donegan/checkbox/fwts_remove_dmidecode_smbios
Merge into: lp://staging/checkbox
Diff against target: 48 lines (+6/-3)
3 files modified
checkbox-old/debian/changelog (+4/-0)
checkbox-old/debian/control (+1/-1)
checkbox-old/scripts/fwts_test (+1/-2)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/fwts_remove_dmidecode_smbios
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+185537@code.staging.launchpad.net

Description of the change

Looks like the FWTS team removed/merged a couple more tests. This branch removes the offending tests (dmi_decode and smbios) and adds the one that was created to merge them (dmicheck)

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

<brendand> cking, has the smbios test been removed from fwts?
<cking> brendand, which version are you referring to?
<brendand> cking, latest stable - 13.09.00-0ubuntu1
<brendand> cking, it doesn't appear in --show-tests on my system for sure
<cking> brendand, https://wiki.ubuntu.com/FirmwareTestSuite/ReleaseNotes/13.08.00 - it got renamed and merged into a new test dmicheck

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks fine, thanks for updating dependencies as well

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches