Checkbox

Merge lp://staging/~brendan-donegan/checkbox/fix_service_file into lp://staging/checkbox

fix_service_file
Merge into trunk

Proposed by Brendan Donegan on 2013-08-23

Status:	Merged
Approved by:	Zygmunt Krynicki on 2013-08-27
Approved revision:	2314
Merged at revision:	2319
Proposed branch:	lp://staging/~brendan-donegan/checkbox/fix_service_file
Merge into:	lp://staging/checkbox
Diff against target:	128 lines (+15/-15) 2 files modified plainbox/contrib/dbus-mini-client.py (+14/-14) plainbox/plainbox/impl/commands/service.py (+1/-1)
To merge this branch:	bzr merge lp://staging/~brendan-donegan/checkbox/fix_service_file
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Zygmunt Krynicki (community)	2013-08-23	Approve on 2013-08-27
Brendan Donegan (community)		Needs Resubmitting on 2013-08-23
Review via email: mp+181728@code.staging.launchpad.net

Description of the change

This fixes the PlainBox service file so that the service starts when a client run that requests the com.canonical.certification.PlainBox bus.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2013-08-23:

Are you sure this is the right name? IIRC we had '1' appended to everything

review: Needs Information

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-08-23:

You have 1 appended to the interface names - e.g. Service1, Whitelist1. This is the unique bus name that is required for activation.

review: Needs Resubmitting

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2013-08-23:

I think we should append 1 to the bus name as well. For reference http://0pointer.de/blog/projects/versioning-dbus.html

Quote:

Version your services! This one is almost as obvious. When you completely rework your D-Bus API introducing a new service name might be a good idea. Best way to do this is by simply bumping the service name. Hence, call your service org.foobar.AwesomeService1 right from the beginning and then bump the version if you reinvent the wheel. And don't forget that you can acquire more than one well-known service name on the bus, so even if you rework everything you can keep compatibilty. (Example: BlueZ 3 to BlueZ 4 switch)

Could we please introduce a patch that changes that to '1' in all the relevant places instead?

lp://staging/~brendan-donegan/checkbox/fix_service_file updated on 2013-08-23