Merge lp://staging/~brendan-donegan/checkbox/bug944762_create_connection_wait into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1294
Proposed branch: lp://staging/~brendan-donegan/checkbox/bug944762_create_connection_wait
Merge into: lp://staging/checkbox
Diff against target: 84 lines (+25/-8)
2 files modified
debian/changelog (+2/-0)
scripts/create_connection (+23/-8)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/bug944762_create_connection_wait
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+95532@code.staging.launchpad.net

Description of the change

Previously create_connection was only running nmcli con up, which depended on the connection to be registered. Sometimes network manager was slow at doing this, so to ensure the connection is registered before trying to bring it up we now poll nmcli con list beforehand until the connection is registered and only then run nmcli con up.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, should be more reliable now.

Merged, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches