Merge lp://staging/~brendan-donegan/checkbox/bug1196531 into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2215
Merged at revision: 2218
Proposed branch: lp://staging/~brendan-donegan/checkbox/bug1196531
Merge into: lp://staging/checkbox
Diff against target: 27 lines (+5/-2)
2 files modified
checkbox-old/debian/changelog (+3/-1)
checkbox-old/plugins/launchpad_report.py (+2/-1)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/bug1196531
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+172351@code.staging.launchpad.net

Description of the change

To try and more sensibly handle the situation where a particular attachment is not relevant to a particular platform, this branch fixes the logic in the launchpad_report plugin to simply not include attachments in the submission.xml whose job state is 'unsupported'

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches