Merge lp://staging/~brendan-donegan/checkbox/bug1185759 into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 2155 |
| Merged at revision: | 2157 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/bug1185759 |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
34 lines (+10/-4) 2 files modified
checkbox-old/debian/changelog (+8/-4) checkbox-old/jobs/optical.txt.in (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/bug1185759 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
cdrom-write jobs were being skipped when run in the Qt UI because they didn't have a proper VERIFICATION section. Unfortunately the Qt UI rather rudely skips manual jobs that aren't formatted properly without telling you why.
Short term fix is to fix up the job description for these jobs. In the long term we should put a better system in to warn about these invalid descriptions.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks okay. Another small thing I've learned today though about checkbox internals :-)