Merge lp://staging/~brendan-donegan/checkbox/bug1184882 into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2165 |
| Merged at revision: | 2168 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/bug1184882 |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
33 lines (+3/-2) 2 files modified
checkbox-old/debian/changelog (+3/-0) checkbox-old/jobs/touchpad.txt.in (+0/-2) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/bug1184882 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
touchpad/horizontal and touchpad/vertical were being skipped on some systems with touchpads that were purely single-touch only, i.e. don't even support two finger scrolling. This is because they were seeking the attribute 'touch_mode == dependent' but such touchpads don't have this attribute.
For now we'll remove the requirement. This may mean these tests run erroneously on some systems and will have to be skipped manually by the tester.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It's a reasonable workaround, and it's been discussed with stakeholders, so +1. Thanks!