Merge lp://staging/~brendan-donegan/checkbox/bug1181952 into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2159 |
| Merged at revision: | 2160 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/bug1181952 |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
67 lines (+14/-3) 4 files modified
checkbox-old/checkbox_qt/qt_interface.py (+1/-1) checkbox-old/debian/changelog (+3/-0) checkbox-old/qt/frontend/qtfront.cpp (+9/-1) checkbox-old/qt/frontend/qtfront.h (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/bug1181952 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
In the Qt UI, the test status was not being preserved when using the previous button to go back through the tests. The status was always shown as skipped. This is a regression from the Gtk UI.
To fix this, we pass the test status to the UI code which selects the appropriate radio button accordingly, or leaves it as skipped if the test status is not either Pass or Fail.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good and works as advertised, thanks! Approving.