Merge lp://staging/~brendan-donegan/checkbox/bug1073335 into lp://staging/checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 1807
Merged at revision: 1831
Proposed branch: lp://staging/~brendan-donegan/checkbox/bug1073335
Merge into: lp://staging/checkbox
Diff against target: 39 lines (+8/-2)
2 files modified
debian/changelog (+5/-1)
scripts/create_connection (+3/-1)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox/bug1073335
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+134648@code.staging.launchpad.net

Commit message

Fix bug 1073335 - replace forward-slash with asterisk when naming connection files in NetworkManager

Description of the change

As discovered at UDS, because of the way NetworkManager stores connection info (as files in '/etc/NetworkManager/system-connections'), having forward slashes in the name would be somewhat problematic. What NetworkManager itself does to get around this is to replace the forward slash with an asterisk, so we must do the same in create_connection. I tested this by changing the SSID of my network at home to include a forward slash and it still works well.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks simple enough, I don't love having asterisks in filenames but if it's legal and consistent with NetworkManager, I'm OK with it. Thanks!

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Attempt to merge into lp:checkbox failed due to conflicts:

text conflict in debian/changelog

1807. By Brendan Donegan

Merged from trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches