checkbox-certification

Merge lp://staging/~brendan-donegan/checkbox-certification/remove_attachments_server_whitelist into lp://staging/checkbox-certification

  1. remove_attachments_server_whitelist
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 607
Merged at revision: 635
Proposed branch: lp://staging/~brendan-donegan/checkbox-certification/remove_attachments_server_whitelist
Merge into: lp://staging/checkbox-certification
Diff against target: 29 lines (+0/-4)
2 files modified
data/server-cert.whitelist (+0/-2)
data/server-selftest.whitelist (+0/-2)
To merge this branch: bzr merge lp://staging/~brendan-donegan/checkbox-certification/remove_attachments_server_whitelist
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Brendan Donegan (community) Needs Resubmitting
Jeff Lane  Approve
Zygmunt Krynicki (community) Approve
Review via email: mp+178551@code.staging.launchpad.net

Commit message

Removes attachment jobs that are not needed on servers from the server whitelists.

Description of the change

These jobs fail in our CI loop because they are not applicable on servers - acpi_sleep_attachment only works where a system supports S3, which server install do not, and installer_debug.gz only works where a system is installed with ubiquity - which a server image never will be.

To post a comment you must log in.
Revision history for this message
Ara Pulido (ara) wrote :

I have put Jeff as reviewer, as this sort of changes needs to be approved by him or Jeff Marcom

Revision history for this message
Daniel Manrique (roadmr) wrote :

nudge, cna we have this reviewed? :)

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good for me.

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

(But I'm not going to approve the whole proposal)

Revision history for this message
Jeff Lane  (bladernr) wrote :

Works for me. Sorry for the trouble they cause in the CI loop, but I guess the loop is working because it's having issues on jobs that don't need to be there in the first place, yes?

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

yes, as long as the loop is finding problems to fix, I guess it can be considered as working :)

Revision history for this message
Daniel Manrique (roadmr) wrote :

Attempt to merge into lp:checkbox-certification failed due to conflicts:

text conflict in debian/changelog

Revision history for this message
Daniel Manrique (roadmr) wrote :

http://www.nooooooooooooooo.com

I can haz changelog fix? :)

Revision history for this message
Daniel Manrique (roadmr) wrote :

Nudge, all we need is a changelog merge and conflict fixing :)

lp://staging/~brendan-donegan/checkbox-certification/remove_attachments_server_whitelist updated
607. By Brendan Donegan

Merged from trunk

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Should be okay now

review: Needs Resubmitting
Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks, approving!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches